Make Node in named_character_references a packed struct #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node being a `struct` instead of a `packed struct(u22)` was a mistake left over from me testing different struct layouts. Switching back to the intended `packed struct(u22)` give a free speedup and a binary size decrease (minus 7KiB):
Benchmark 1 (637 runs): bench-autostruct.exe
measurement mean ± σ min … max outliers delta
wall_time 7.85ms ± 203us 7.56ms … 11.2ms 18 ( 3%) 0%
peak_rss 2.89MB ± 8.99KB 2.89MB … 3.12MB 39 ( 6%) 0%
Benchmark 2 (720 runs): bench-packedstructu22.exe
measurement mean ± σ min … max outliers delta
wall_time 6.94ms ± 177us 6.71ms … 8.80ms 36 ( 5%) ⚡- 11.6% ± 0.3%
peak_rss 2.88MB ± 8.46KB 2.88MB … 3.11MB 45 ( 6%) - 0.3% ± 0.0%
|
Thank you very much Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node being a
structinstead of apacked struct(u22)was a mistake left over from me testing different struct layouts when preparing #11 (whoops!). Switching back to the intendedpacked struct(u22)gives a free speedup and a binary size decrease (minus 7KiB for me):